Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Also deploy maven artefacts for GraalVM CE build #566

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Sep 12, 2023

The CI change done in #565 changed the quarkus build to depend on the maven artefacts from the mandrel/graalvm build. It adjusted the mandrel build to produce the maven artefacts, but missed updating the GraalVM CE (or now GraalVM Community) build to do the same. Thus the quarkus build fails, since it wants to download the archived maven repo from the mandrel/graalvm build. This patch should fix it.

Test run with this is here (keeping in draft until that run completes):
https://github.com/jerboaa/graal/actions/runs/6157493384/job/16709008677

@jerboaa jerboaa requested a review from zakkak September 12, 2023 09:47
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 12, 2023
@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 12, 2023

Quarkus build in the check is now progressing. Moving out of draft.

@jerboaa jerboaa marked this pull request as ready for review September 12, 2023 10:06
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 12, 2023

Thanks for the review!

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 12, 2023

OK, the CI run is all red in IT tests because of quarkusio/quarkus#35847 I'll merge.

@jerboaa jerboaa merged commit 949c29e into graalvm:default Sep 12, 2023
124 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants