Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Oracle GraalVM for JDK 21 #221

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Conversation

olyagpl
Copy link
Member

@olyagpl olyagpl commented Dec 7, 2023

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 7, 2023
@olyagpl olyagpl requested a review from sachin-pikle December 7, 2023 15:30
@olyagpl olyagpl requested a review from LesiaChaban December 7, 2023 16:30
@olyagpl
Copy link
Member Author

olyagpl commented Dec 7, 2023

I had made this demo look and run using the same settings and versions as Jibber demo used in this Luna Lab https://luna.oracle.com/lab/268ea851-2f09-43e6-8d70-40a10cb4de03. GitHub Action workflow passed.

@LesiaChaban LesiaChaban self-requested a review December 8, 2023 11:16
@sachin-pikle
Copy link
Collaborator

Made some updates to the readme and pom.xml.

Copy link
Collaborator

@sachin-pikle sachin-pikle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sachin-pikle sachin-pikle merged commit 77f7b4b into master Dec 8, 2023
5 checks passed
@sachin-pikle sachin-pikle deleted the og/spring-native-image branch December 8, 2023 16:07
@@ -1,5 +1,5 @@
# Using Oracle GraalVM for JDK 17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachin-pikle maybe we should update the comment too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Will fix it in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants