Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip color-space-conversion test if no ImageData #4185

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Skip color-space-conversion test if no ImageData #4185

merged 2 commits into from
Feb 11, 2025

Conversation

greggman
Copy link
Contributor

No description provided.

@greggman greggman requested a review from shrekshao February 11, 2025 22:38
shrekshao
shrekshao approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment

src/webgpu/util/texture/color_space_conversions.spec.ts Outdated Show resolved Hide resolved
@greggman greggman enabled auto-merge (squash) February 11, 2025 23:01
@greggman greggman merged commit 294a0e3 into gpuweb:main Feb 11, 2025
1 check passed
@greggman greggman deleted the skip-imagedata branch February 11, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrekshao shrekshao shrekshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greggman @shrekshao