Compat: refactor storage_texture tests #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
force-pushed
the
storage_texture_without_storage_buffers
branch
from
d20b754 to
4cb343a
Compare
greggman
force-pushed
the
storage_texture_without_storage_buffers
branch
from
4cb343a to
549ba12
Compare
1. Skip them if there are no storage textures 2. Refactor them so they don't need storage buffers to test. Also did some minor JavaScript stlying. I hope that's okay. While the CTS doesn't have a style guide, JS is generally methods, properties, and variable names are camelCase and classes are CamelCase.
greggman
force-pushed
the
storage_texture_without_storage_buffers
branch
from
549ba12 to
3ad1985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip them if there are no storage textures
Refactor them so they don't need storage buffers to test.
Also did some minor JavaScript styling. I hope that's okay. While the CTS doesn't have a style guide, JavaScript is generally methods, properties, and variable names are
camelCaseand classes areCamelCase.