Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Add AF select execution tests #3077

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

zoddicus
Copy link
Contributor

Fixes #3076


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Oct 19, 2023
@zoddicus zoddicus self-assigned this Oct 19, 2023
@github-actions
Copy link

Previews, as seen when this build job started (6fb3e20):
Run tests | View tsdoc

Copy link
Contributor

@jiangzhaoming jiangzhaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@@ -133,7 +140,7 @@ g.test('scalar')

await run(
t,
builtin('select'),
t.params.component !== 'af' ? builtin('select') : abstractBuiltin('select'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. I would flip the condition around and rephrase it in the positive sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a similar one later too.

not a blocking request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@github-actions
Copy link

Previews, as seen when this build job started (84f73d5):
Run tests | View tsdoc

@zoddicus zoddicus merged commit 3148e15 into gpuweb:main Oct 23, 2023
2 checks passed
@zoddicus zoddicus deleted the addAFSelectTests branch October 23, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wgsl: Add AbstractFloat select execution tests
3 participants