wgsl: Add AF remainder (%) execution tests #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on division PR, so new code is in the last patch, f9dcf2b |
zoddicus
force-pushed
the
addAFRemainderTests
branch
from
f9dcf2b to
d4df945
Compare
|
Previews, as seen when this build job started (d4df945): |
jiangzhaoming
approved these changes
Oct 20, 2023
dneto0
approved these changes
Oct 20, 2023
src/unittests/floating_point.spec.ts
Outdated
| @@ -4400,17 +4405,21 @@ g.test('divisionInterval') | |||
| }) | |||
| ) | |||
| .fn(t => { | |||
| const trait = FP[t.params.trait]; | |||
| // This is a ULP based interval, so abstract should behave like f32, so | |||
There was a problem hiding this comment.
Side task: After a quick review it looked like the FP primer didn't discuss this issue (i.e. using f32 error tolerances for AbstractFloat tolerances for operations whose errors are expressed in ULPs, and why). Please update it.
There was a problem hiding this comment.
Issue filed, #3079
zoddicus
force-pushed
the
addAFRemainderTests
branch
from
d4df945 to
9c025aa
Compare
|
Previews, as seen when this build job started (9c025aa): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1626
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.