Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New clarification prompt #715

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

lukaspetersson
Copy link
Contributor

@lukaspetersson lukaspetersson commented Sep 18, 2023

#708 and #703

tldr: clarification flow is confusing for user and adds unnecessary information that confuses GPT.

Note: does not make the list of clarifications anymore.

I would love feedback on whether this could cause unexpected consequences.

@lukaspetersson lukaspetersson marked this pull request as ready for review September 18, 2023 06:38
@AntonOsika
Copy link
Collaborator

I think clarify is very much a UX questions.

Are you confident this doesn't make it unstable/degrade behavior/etc?

We could also just go for #717 instead

@lukaspetersson
Copy link
Contributor Author

I think clarify is very much a UX questions.

Are you confident this doesn't make it unstable/degrade behavior/etc?

We could also just go for #717 instead

#717 just hides clarify, but it still leaves all the problems with it if user decides to use it.

I ran it a couple of times (twice on 2 different cases) and I very much prefered the UX over the current version. It results in a shorter total prompt, which is beneficial I think, but this is just speculation and intuition.

@AntonOsika
Copy link
Collaborator

Cool let’s go

@AntonOsika AntonOsika merged commit a38bd55 into gpt-engineer-org:main Sep 19, 2023
4 checks passed
@lukaspetersson lukaspetersson deleted the clarify branch September 22, 2023 17:28
70ziko pushed a commit to 70ziko/gpt-engineer that referenced this pull request Oct 25, 2023
* New clarification prompt

* format

* dead line bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants