Usability improvements #1191
Usability improvements #1191
Conversation
There was a problem hiding this comment.
Great job overall! The implementation looks solid, and the functionality is well thought out. The main thing needed now is to add tests. You can find the test cases test_main.py. Since there isn't a specific test case for the file selector, please write some tests for the main process to ensure everything passes.
There was a problem hiding this comment.
The increased timeout from 1 to 10 seconds improves robustness but may excessively prolong execution. Consider a shorter timeout (e.g., 3-5 seconds) to balance reliability and performance.
There was a problem hiding this comment.
Defaulted to 3 secs.
Added a new command line parameter "--diff_timeout INTEGER" to override.
Also created some test in tests/application/cli/test_main.py:test_improve_existing_project_diff_timeout for the new command line option.
There was a problem hiding this comment.
Great work on defaulting time and adding the new command line parameter for overriding. The test you created for this is a nice addition.
There was a problem hiding this comment.
Great idea! We're implementing this to save user time by skipping file selection. This will be included in a uniform config file where users can set all configurations, including the model. Sorting files is a good suggestion. Please add tests for these features.
There was a problem hiding this comment.
Added tests:
- tests/core/test_file_selector_enhancements.py: test_file_selector_enhancement_skip_file_selector
- tests/core/test_file_selector_enhancements.py: test_file_selector_enhancement_sort
There was a problem hiding this comment.
Thanks for adding the tests for the file selector enhancements. I appreciate your thoroughness in testing both skipping and sorting.
There was a problem hiding this comment.
Good location for user interface functions. We plan to move most functions into the config file. Please add tests for these features.
There was a problem hiding this comment.
Added test:
- tests/application/cli/test_main.py:test_improve_existing_project_skip_file_selection
There was a problem hiding this comment.
Valuable enhancement. Thanks for covering this aspect.
There was a problem hiding this comment.
Good suggestion to support multiple languages. We will keep this feature as suggested.
There was a problem hiding this comment.
Also added Arduino *.ino files. They are basically C++ with some extra functions like "setup()" and "loop()" - works well with ChatGPT & DeepSeek.
There was a problem hiding this comment.
Including the Arduino *.ino files was a smart move. It's good to know they integrate well with ChatGPT & DeepSeek.
@jtoberling Thank you for your meaningful contributions! Your efforts have significantly impacted us, and we truly appreciate your dedication. We love having talented and passionate contributors like you on the team. Keep up the great work! |
|
@jtoberling I fully agree with the changes you’ve made and approve this PR. We'll discuss this further in our next group meeting. Great job! |
Improvement mode toml filelist have to be in full-path sorted mode.
By using large project the current listing is "mixed" and very hard to use.
Increasing timeout value in chat_to_files finditer.
By using DeepSeek API with "deepseek-coder" model without this timeout increment the resolution of completion is timing out quite frequently.
Adding "--skip-file-selection" / "-s" command line option to skip toml file selection editor in improvement mode.
By using it in complex projects and repetitive tasks the file selector popup is especially disturbing and against usabilty.
Please consider to merge the above points as they are leading to a more smooth usability experiment.