-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usability improvements #1191
Usability improvements #1191
Changes from 7 commits
a682ce3
fec73f3
450834e
d281896
03ad758
543d596
b45019f
a4bbb37
7fa07e7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good location for user interface functions. We plan to move most functions into the config file. Please add tests for these features. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added test:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Valuable enhancement. Thanks for covering this aspect. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The increased timeout from 1 to 10 seconds improves robustness but may excessively prolong execution. Consider a shorter timeout (e.g., 3-5 seconds) to balance reliability and performance. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Defaulted to 3 secs. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great work on defaulting time and adding the new command line parameter for overriding. The test you created for this is a nice addition. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good suggestion to support multiple languages. We will keep this feature as suggested. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also added Arduino *.ino files. They are basically C++ with some extra functions like "setup()" and "loop()" - works well with ChatGPT & DeepSeek. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Including the Arduino *.ino files was a smart move. It's good to know they integrate well with ChatGPT & DeepSeek. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! We're implementing this to save user time by skipping file selection. This will be included in a uniform config file where users can set all configurations, including the model. Sorting files is a good suggestion. Please add tests for these features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests for the file selector enhancements. I appreciate your thoroughness in testing both skipping and sorting.