Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map missing prop description in toMediaItem #105

Conversation

timjonischkat
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind bug

What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
fixes the missing mapping for MediaItem.Description, leaving all Descriptions empty when retrieving from the API

Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
no

Does this pull request add new dependencies?
no

What else do we need to know?

@pacoorozco
Copy link
Member

Hi @timjonischkat

I'm very sorry I miss the notification about this PR. I'm going to merge it right now.

I'll add a test later

Thanks a lot for your contribution.

@pacoorozco pacoorozco merged commit 185ab89 into gphotosuploader:main Oct 7, 2023
@pacoorozco pacoorozco mentioned this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants