Skip to content
This repository has been archived by the owner on Mar 23, 2018. It is now read-only.

Do nothing if the target filesystem is not the default #8

Merged
merged 1 commit into from
Aug 20, 2016

Conversation

jonathanperret
Copy link
Contributor

Fix #7 by detecting a non-standard output file system and bailing out.

In particular, `webpack-dev-server` forces an in-memory filesystem and
sets the output path to `/`, breaking this plugin. Fixes gpbl#7.
@jonathanperret
Copy link
Contributor Author

A more flexible fix would use methods on the provided compiler.outputFileSystem to do the work, but that would require reimplementing recursive-readdir-sync which is hard-wired to fs.

@jonathanperret
Copy link
Contributor Author

Scratch that, NodeOutputFileSystem does not expose the necessary methods: https://github.com/webpack/webpack/blob/master/lib/node/NodeWatchFileSystem.js

@tekacs
Copy link

tekacs commented Jul 23, 2016

Any chance this can be merged and the version bumped (here and on NPM)? @gpbl

@gpbl gpbl merged commit 47f565d into gpbl:master Aug 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants