This repository has been archived by the owner on Mar 23, 2018. It is now read-only.
Relative output path support #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
reviewed
Feb 13, 2017
| .filter(file => | ||
| exclude.every(excluded => | ||
| !minimatch(file, path.join(excluded), { dot: true }) | ||
| !minimatch(path.relative(fromPath, file), path.join(excluded), { dot: true }) |
There was a problem hiding this comment.
Can the path.relative call be cached outside of the function passed to exclude.every?
There was a problem hiding this comment.
yes sure i don't see any issue here as long the tests still pass 👍
|
@bassarisse can you please rebase your work. #25 was recently accepted, which changed the contents of @foxbunny and @gpbl I've tested this change to |
|
@destroyerofbuilds thanks for testing this! |
|
See #28 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies
getFilesfunction and add support for relative output path in Webpack config, like so:What do you think? Would it incorrectly affect something?