Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine UMD configs with rollup multiconfig and add size snapshot #678

Closed
wants to merge 4 commits into from
Closed

Combine UMD configs with rollup multiconfig and add size snapshot #678

wants to merge 4 commits into from

Conversation

TrySound
Copy link
Contributor

This will reduce cost of running node and loading rollup twice.

@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #678 into v8 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##             v8   #678   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        15     15           
  Lines       617    617           
  Branches    135    135           
===================================
  Hits        617    617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a808f...9c81dc1. Read the comment docs.

@gpbl
Copy link
Owner

gpbl commented Mar 23, 2018

Some more explanation please? :)

@TrySound
Copy link
Contributor Author

I have a plan to distribute also cjs and esm bundles instead of many files. This will also reduce the cost of bundling vendors.

@TrySound
Copy link
Contributor Author

Added rollup-plugin-size-snapshot. I created this plugin for improving bundles of frontend projects.

@TrySound TrySound changed the title Combine UMD configs with rollup multiconfig Combine UMD configs with rollup multiconfig and add size snapshot Mar 24, 2018
@gpbl
Copy link
Owner

gpbl commented Mar 24, 2018

I have a plan to distribute also cjs and esm bundles instead of many files. This will also reduce the cost of bundling vendors.

Sorry I don’t follow, could you explain? Thanks!

@gpbl
Copy link
Owner

gpbl commented Mar 24, 2018

Added rollup-plugin-size-snapshot. I created this plugin for improving bundles of frontend projects.

Which projects are you talking about? What does improve?

@TrySound
Copy link
Contributor Author

TrySound commented Mar 24, 2018

Currently webpack or rollup to bundle react-day-picker dependency looks through all files spending the time of build. We can provide a single bundle like react itself does. So bundler will spend the time to resolve only one file per dependency.

Also with such bundle we will have better control over size which user consumes. size snapshot plugin have option to track treeshakability by creating internal bundle with import {} from 'react-day-picker'.

@TrySound
Copy link
Contributor Author

TrySound commented Mar 30, 2018

Any thoughts?

@gpbl gpbl added this to the v8.0.0 milestone Apr 14, 2018
@gpbl gpbl closed this Oct 17, 2019
@gpbl
Copy link
Owner

gpbl commented Oct 17, 2019

@TrySound thanks this work has landed into #944. Would love a review there, if you still have time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants