Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next and previous Month doesn't work without react-tap-event-plugin installed #1

Closed
rach opened this issue Jan 13, 2015 · 2 comments
Closed

Comments

@rach
Copy link

rach commented Jan 13, 2015

No click event exist for this actions.
https://github.com/gpbl/react-day-picker/blob/master/src/DayPicker.js#L96-L103

It's maybe not necessary to fix it but maybe amending the doc to say that react-tap-event-plugin is required.

Otherwise I really like the work that you have done with with calendar component, it leave loads of room for flexible behavior.. Exactly what I needed. Thanks

@gpbl
Copy link
Owner

gpbl commented Jan 14, 2015

thanks @rach ! You are right. What do you think could be the best approach?

  1. remove the click events at all and impose the use of react-tap-event-plugin
  2. use click events (not touch) for the navigation buttons

I'd go with the first.

@gpbl gpbl closed this as completed in 421afb6 Jan 17, 2015
@rach
Copy link
Author

rach commented Jan 18, 2015

Thanks for the fix.
I was going to say that 2) was a better choice so if people doesn't care about mobile tap event.
Great lib, thanks again for sharing it.

gpbl pushed a commit that referenced this issue Oct 20, 2017
gpbl added a commit that referenced this issue May 5, 2024
Signed-off-by: gpbl <io@gpbl.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants