Skip to content

Commit

Permalink
fix typo HR10+ -> HDR10+ - fix #63
Browse files Browse the repository at this point in the history
  • Loading branch information
rbouqueau committed Jun 3, 2023
1 parent 324d251 commit 88d9261
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/specs/av1_hdr10plus/av1_hdr10plus.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -461,19 +461,19 @@ const SpecDesc specAv1Hdr10plus =
seenFrameHeader = true;

if(obu.isHdr10p && seenFrameHeader)
out->error("The HR10+ metadata OBU shall precede the frame header (Temporal Unit #%d, Frame #%d)", tu, frame);
out->error("The HDR10+ metadata OBU shall precede the frame header (Temporal Unit #%d, Frame #%d)", tu, frame);

if(obu.type == OBU_FRAME)
seenFrame = true;

if(obu.isHdr10p && seenFrame)
out->error("The HR10+ metadata OBU shall be located after the last OBU of the previous frame if any (Temporal Unit #%d, Frame #%d)", tu, frame);
out->error("The HDR10+ metadata OBU shall be located after the last OBU of the previous frame if any (Temporal Unit #%d, Frame #%d)", tu, frame);

if(obu.type == OBU_SEQUENCE_HEADER)
seenSeqHdr = true;

if(obu.isHdr10p && hasSeqHdr && !seenSeqHdr)
out->error("The HR10+ metadata OBU shall be located after the Sequence Header if any (Temporal Unit #%d, Frame #%d)", tu, frame);
out->error("The HDR10+ metadata OBU shall be located after the Sequence Header if any (Temporal Unit #%d, Frame #%d)", tu, frame);
}
}
}
Expand Down
2 changes: 2 additions & 0 deletions src/utils/spec_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ SpecDesc const* specFind(const char* name)
return spec;

fprintf(stderr, "Spec '%s' not found: possible values are:", name);

for(auto& spec : g_allSpecs())
fprintf(stderr, " '%s'", spec->name);

fprintf(stderr, ".\n");
fflush(stderr);
exit(1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Specification description: HDR10+ AV1 Metadata Handling Specification, 7 Decembe
https://github.com/AOMediaCodec/av1-hdr10plus/commit/63bacd21bc5f75ea6094fc11a03f0e743366fbdf
https://aomediacodec.github.io/av1-hdr10plus/

[av1hdr10plus][Rule #9] Error: The HR10+ metadata OBU shall be located after the last OBU of the previous frame if any (Temporal Unit #0, Frame #0)
[av1hdr10plus][Rule #9] Error: The HDR10+ metadata OBU shall be located after the last OBU of the previous frame if any (Temporal Unit #0, Frame #0)

========================================
[av1hdr10plus] 1 error(s), 0 warning(s).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Specification description: HDR10+ AV1 Metadata Handling Specification, 7 Decembe
https://github.com/AOMediaCodec/av1-hdr10plus/commit/63bacd21bc5f75ea6094fc11a03f0e743366fbdf
https://aomediacodec.github.io/av1-hdr10plus/

[av1hdr10plus][Rule #9] Error: The HR10+ metadata OBU shall be located after the last OBU of the previous frame if any (Temporal Unit #0, Frame #0)
[av1hdr10plus][Rule #9] Error: The HDR10+ metadata OBU shall be located after the last OBU of the previous frame if any (Temporal Unit #0, Frame #0)

========================================
[av1hdr10plus] 1 error(s), 0 warning(s).
Expand Down
2 changes: 1 addition & 1 deletion tests/av1hdr10plus/invalid_metadata_position_seqhdr.ref
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Specification description: HDR10+ AV1 Metadata Handling Specification, 7 Decembe
https://github.com/AOMediaCodec/av1-hdr10plus/commit/63bacd21bc5f75ea6094fc11a03f0e743366fbdf
https://aomediacodec.github.io/av1-hdr10plus/

[av1hdr10plus][Rule #9] Error: The HR10+ metadata OBU shall be located after the Sequence Header if any (Temporal Unit #0, Frame #0)
[av1hdr10plus][Rule #9] Error: The HDR10+ metadata OBU shall be located after the Sequence Header if any (Temporal Unit #0, Frame #0)

========================================
[av1hdr10plus] 1 error(s), 0 warning(s).
Expand Down

0 comments on commit 88d9261

Please sign in to comment.