Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_fmt_char supports standard data types #120

Merged
merged 10 commits into from
Jul 26, 2024
Merged

as_fmt_char supports standard data types #120

merged 10 commits into from
Jul 26, 2024

Conversation

gowerc
Copy link
Owner

@gowerc gowerc commented Jul 26, 2024

Closes #119

Not even sure how this went un-detected but the lack of a default method meant things like dates / datetime were throwing errors when trying to be converted to character.

Copy link
Contributor

github-actions bot commented Jul 26, 2024

badge

Code Coverage Summary

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  --------------------------
R/ascii_tables.R          114       8  92.98%   10, 154, 164, 169-172, 231
R/cast_variables.R         49       0  100.00%
R/diffdf.R                188      18  90.43%   358-375, 402
R/generate_keyname.R       10       1  90.00%   16
R/identify.R              152       8  94.74%   283-290
R/is_different.R           52       0  100.00%
R/issuerows.R              40       0  100.00%
R/issues.R                 17       1  94.12%   51
R/misc_functions.R         34       2  94.12%   9, 13
R/print.R                  20       0  100.00%
TOTAL                     676      38  94.38%

Results for commit: 20716b3

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Unit Tests Summary

  1 files   12 suites   6s ⏱️
 51 tests  49 ✅ 2 💤 0 ❌
582 runs  574 ✅ 8 💤 0 ❌

Results for commit 20716b3.

♻️ This comment has been updated with latest results.

kieranjmartin
kieranjmartin previously approved these changes Jul 26, 2024
@gowerc gowerc merged commit ec5f643 into master Jul 26, 2024
23 checks passed
@gowerc gowerc deleted the 119-fix-dates branch July 26, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date class can't be printed
2 participants