Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLH-1958-fix-code-pipeline-failing-tests-on-frontend-pipeline #1610

Merged
merged 3 commits into from
Aug 15, 2024
Merged

OLH-1958-fix-code-pipeline-failing-tests-on-frontend-pipeline #1610

merged 3 commits into from
Aug 15, 2024

Conversation

latifcabinetoffice
Copy link
Contributor

@latifcabinetoffice latifcabinetoffice commented Aug 15, 2024 •
edited by jira bot
Loading

Proposed changes

OLH-1958 Security group update to only VPC, Added cloudfront log to access logs, corrected api gateway alarm to 5%

What changed

  1. Security group ingress rule was configured for all internet. Has been changed to 10.0.0.0/16 which is the VPC.
  2. Changed CloudFront Logs to use the access logs bucket
  3. ApiGateway4xxStatusAlarm false triggers as it is configured for 0.05% instead of 5%

Why did it change

To resolve pipeline failing tests.

Checklists

Environment variables or secrets

  • No environment variables or secrets were added or changed

Testing

Left in Dev for ~ a week to validate no issues.

@latifcabinetoffice latifcabinetoffice requested a review from a team as a code owner August 15, 2024 08:44
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@latifcabinetoffice latifcabinetoffice added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit 8796e28 Aug 15, 2024
8 checks passed
@latifcabinetoffice latifcabinetoffice deleted the OLH-1958-fix-code-pipeline-failing-tests-on-frontend-pipeline branch August 15, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aenciso aenciso aenciso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latifcabinetoffice @aenciso