Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original approach used
GetSystemMetrics()
which actually returned minimal possible size of a window in pixels (most likely even without paying attention to non-zero border sizes).I'm switching it to already used
GetConsoleScreenBufferInfo()
(already used inwriter_windows.go
) which among others returns currently visible window (from which terminal size could be easily calculated).Without that fix uiprogress on Windows almost always clears the window because it erroneously detects overflows when they aren't actually present.