Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some order dependent tests #83

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

vannem-sj
Copy link
Contributor

These tests were modifying global state and not resetting it. Clearing the CustomSub lets the tests run in any order.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #83 (91ec822) into master (1eab316) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          142       142           
=========================================
  Hits           142       142           

@matrixik matrixik added the tests label Feb 23, 2024
@matrixik matrixik merged commit 76470d7 into gosimple:master Feb 23, 2024
6 checks passed
@matrixik
Copy link
Member

Thank you for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants