Prevent invalid array access #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP7.4 - https://www.php.net/manual/en/migration74.incompatible.php > Trying to use values of type null, bool, int, float or resource as an array (such as $null["key"]) will now generate a notice.
|
Any timeline on getting this merged? |
|
This is causing alot of notices in the logs, please merge this fix. |
|
@josephmancuso I've just packaged up a release -> https://github.com/goshippo/shippo-php-client/releases/tag/v1.4.4 let me know if this doesn't address the issue! |
|
@jfriedr yeah but can we get it on packagist? latest release downloads 1.4.3 still. |
|
@josephmancuso apologies looks like I missed this last message. After taking a look at packagist I noticed that there was a more recent version. Note that we have a webhook to publish new versions. This most recent change was done automatically.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP7.4 - https://www.php.net/manual/en/migration74.incompatible.php