Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not handle network error in SetCloseHandler() #863

Merged
merged 4 commits into from
Jan 22, 2024

Revert "Print log message"

42fd2c0
Select commit
Loading
Failed to load commit list.
Merged

Do not handle network error in SetCloseHandler() #863

Revert "Print log message"
42fd2c0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2024 in 0s

71.21% (+0.69%) compared to 871f6bb

View this Pull Request on Codecov

71.21% (+0.69%) compared to 871f6bb

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (871f6bb) 70.52% compared to head (42fd2c0) 71.21%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
+ Coverage   70.52%   71.21%   +0.69%     
==========================================
  Files          11       11              
  Lines        1591     1584       -7     
==========================================
+ Hits         1122     1128       +6     
+ Misses        358      349       -9     
+ Partials      111      107       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.