Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flate write pool size to work with best compression #208

Merged
merged 2 commits into from
Jan 24, 2017
Merged

fix flate write pool size to work with best compression #208

merged 2 commits into from
Jan 24, 2017

Conversation

FZambia
Copy link
Contributor

@FZambia FZambia commented Jan 24, 2017

Currently SetCompressionLevel panics: index out of range.

@garyburd
Copy link
Contributor

Thanks for spotting this. There's also an issue with level -2. It's only supported on Go 1.7 and up.

@FZambia FZambia mentioned this pull request Jan 24, 2017
Closed
@FZambia
Copy link
Contributor Author

FZambia commented Jan 24, 2017

Maybe just remove this test then? It actually does not check too much

@garyburd
Copy link
Contributor

Yes, remove the test.

@garyburd garyburd merged commit 4e4c8d0 into gorilla:master Jan 24, 2017
@gorilla gorilla locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FZambia @garyburd