fix: resume close animation when container gets resized (#1374) #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorhom
force-pushed
the
fix/close-animation
branch
from
cfe2bb6 to
7eadf7e
Compare
gorhom
changed the title
|
@gorhom i believe this happens on v5(on IOS) too with the |
gorhom
added a commit
that referenced
this pull request
Jun 25, 2023
I was having a similar issue with |
|
I'll pick this fix to v5 later today |
|
Hello @gorhom is this fixed(it seems not fixed) on v5 i was searching commit history but did not found changes on v5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1374
Motivation
In Android when the
windowSoftInputModeis set toadjustResize, it will resize the entire the app when the keyboard appears. This causes a conflict with the close position where it set to be the container height.The fix will ensure that close animation will be corrected whenever the container height gets updated.