Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add negative 1 value #3927

Closed
wants to merge 1 commit into from
Closed

Add negative 1 value #3927

wants to merge 1 commit into from

Conversation

ryanbr
Copy link
Contributor

@ryanbr ryanbr commented Oct 23, 2024

From AdguardTeam/AdguardFilters@5697ba4

There could be 2 ways of fixing this, include negative values or this way. Happy with either option tbh.

! reject
gdh.digital##+js(set-local-storage-item, cookie_accepted, -1)

@gorhill
Copy link
Owner

gorhill commented Nov 5, 2024

Currently set-cookie accepts integers between 0 and 32767. I don't see a reason why it should not also accept integer from the -32767 to 32767 range. I prefer to make changes to set-cookie to accept negative integers.

gorhill added a commit that referenced this pull request Nov 7, 2024
@gorhill
Improve set-cookie scriptlet
e613282 
Allow negative integer as valid value.

Related issue:
#3927

Additionally, move cookie-related scriptlets/helpers into its own
source code file.
@gorhill
Copy link
Owner

gorhill commented Nov 8, 2024

Negative value down to -32767 are supported in current dev build: e613282698

@gorhill gorhill closed this Nov 8, 2024
@gorhill
Copy link
Owner

gorhill commented Nov 8, 2024

Err sorry, I did the change for set-cookie but not for set-local-storage-item. This will be in next dev build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanbr @gorhill