Attempted to increase the "lists too many" treshold #3909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This limit is here for technical reasons. Too long text will cause error on GitHub side, and you will be not able to post new issue. It can be make smarter - when there are a low number of domains blocked and extended filters reported then allow more lists to be shown, but it's more work. |
|
On the other hand, when manually copying the info, there should be no problem. It only happens when creating issue directly from uBO interface. And an idea - uBO can send only a token in a new issue URL and then fill the form by script injected on new issue URLs. Lot of work. |
|
Declined because of uBlockOrigin/uBlock-issues#1852. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In large part inspired by DandelionSprout/adfilt#960, it has turned out that a limit of 12 added lists in the User Support settings info is unfortunately too low for at least me. The result of the limit was that I had no idea if that reporter had Frellwit's Filters turned on or not, and I take an unqualified guess that Frellwit was unsure too.
So I attempted to increase it from 12 to 25. 20 didn't feel like enough, while 30 would seem like a pretty big change for a PR.
I don't think this change will affect anyone else's filterlist maintenances, so I hope that this is indeed suited as a PR. On request, I could set up a uBlock-issues thread connected to this PR for broader communications and such.