Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBO's dashboard does not refresh custom filters in real-time #3704

Closed
KonoromiHimaries opened this issue Apr 12, 2018 · 4 comments
Closed

uBO's dashboard does not refresh custom filters in real-time #3704

KonoromiHimaries opened this issue Apr 12, 2018 · 4 comments

Comments

@KonoromiHimaries
Copy link

KonoromiHimaries commented Apr 12, 2018

Describe the issue

example. i create new rule with injector
2018-04-12-test 2

then i move to my filters panel and i doesn't see any change
2018-04-12-ublock panel sterowania

i still must use refresh button or f5 to see any change
2018-04-12-ublock panel sterowania

One or more specific URLs where the issue occurs

http://docelowtestowych.cba.pl/index.php/test-2/

Your settings

  • OS/version: win10
  • Browser/version: chrome 65.0.3325.181
  • uBlock Origin version: 1.15.24
@uBlock-user
Copy link
Contributor

By design. The real time update was never added in the first place.

@gorhill
Copy link
Owner

gorhill commented Apr 12, 2018

The complication is that the user could have changes not yet applied -- so you cannot just replace the current list with the modified one.

I do agree this is an issue though, I did lose filters created with the element picker in the past because of this. I think it's solvable now that uBO is equipped with a proper differ (used in the My rules pane).
Cases:

  • No changes => just reload the modified list.
  • Un-committed changes => use the differ to add/remove incrementally.

In all cases, as much as possible preserve scroll and cursor position.

gorhill added a commit that referenced this issue Jul 17, 2021
@gorhill gorhill changed the title ublock dashboard not refresh filters list in real-time uBO's dashboard does not refresh custom filters in real-time Jul 17, 2021
@gwarser
Copy link
Contributor

gwarser commented Jul 18, 2021

Fixed.

@gorhill gorhill closed this as completed Jul 18, 2021
@uBlock-user
Copy link
Contributor

uBlock-user commented Jul 18, 2021

Label should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants