-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate pseudo operator :if(...)
, :if-not(...)
, reuse :has(...)
, :not(...)
#3683
Comments
:if(...)
, :if-not(...)
, reuse :has(...)
and add :has-not(...)
:if(...)
, :if-not(...)
, reuse :has(...)
, :not(...)
Related issue: <#3683> Additionally, improve compile-time error reporting in the logger
If the last commit proves to work as expected, that should solve the issue here. |
Last commit was about uBlockOrigin/uBlock-issues#341 (comment)
|
Can you pleas check wiki and describe how this should work from your point of view? https://github.com/gorhill/uBlock/wiki/Procedural-cosmetic-filters#subjectnotarg |
I reviewed the doc. Note that I referred to the issue here in the commit because the original commit in the other issue was not really fixing the issue raised, it was however addressing partially the issue here. |
Related issue: - #3683 This commit further increases uBO's procedural cosmetic filters Adguard's cosmetic filter syntax -- specifically those procedural cosmetic filters where plain CSS selectors appeared following a procedural oeprator (this was rejected as invalid by uBO). Also, experimental support for `:watch-attrs` procedural operator, as discussed in <uBlockOrigin/uBlock-issues#341 (comment)>. Support may be dropped before next release depending on whether a better solution is suggested. Additionally, the usual opportunistic refactoring toward ES6 syntax.
Updating syntaxes based on latest uBO changes. script:inject(...) >> +js(...), : https://github.com/gorhill/uBlock/wiki/Static-filter-syntax :if(...), :if-not(...) >> :has(...), :not(...), : gorhill/uBlock#3683
A while ago I modified the behavior of
:has(...)
to behave like:if(...)
in order to more easily translate Adguard's own pseudo-operators. To simplify things I should just deprecate:if(...)
/:if-not(...)
, to be replaced with:has(...)
/:not(...)
(Adguard uses:not(...)
).The parser will translate deprecated
:if(...)
/:if-not(...)
, but eventually in some future support should be removed completely.The text was updated successfully, but these errors were encountered: