-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
userResourcesLocation URL appears twice in the logger #3586
Comments
P.S - As seen from the screenshot, the network requests are shown as |
This has always been behind the scene, these are requests made by uBO, there is no tab associated with the extension. |
Really ? I remembered differently perhaps.. |
Can no longer reproduce this, so closing. Logger refactorisation must have taken care of this for good. |
I could reproduce today. There is a race condition so this may or may not be reproduced according to how fast resources are updated. If they update fast, the resource file may be pulled twice. Anyway, I will push an update where this is fixed. |
The URLs must be space-separated. Reminders: - The additional resources will be updated at the same time the built-in resource file is updated - Purging the cache of 'uBlock filters' will also purge the cache of the built-in resource file -- and hence force a reload of the user's custom resources if any Related issues: - #3307 - uBlockOrigin/uAssets#5184 (comment) Addtionally: - Opportunitically promisified assets.fetchText() - Fixed #3586
Describe the issue
userResourcesLocation
URL appears twice in the logger when uBlock Filters is updated.Screenshot in which the issue can be seen
Steps for anyone to reproduce the issue
Open Advanced Settings page and paste
https://raw.githubusercontent.com/uBlock-user/uBO-Scriptlets/master/scriptlets.txt
atuserResourcesLocation
as the URL and save it.Open 3rd party Filters page and open the logger page for it, now click on the clock icon near uBlock Filters, followed by clicking on
Update Now
button.Observe the logger page and notice there's a double entry for
https://raw.githubusercontent.com/uBlock-user/uBO-Scriptlets/master/scriptlets.txt
Your settings
The text was updated successfully, but these errors were encountered: