Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup appears for a split second when searching on The Pirate Bay using Firefox #1324

Closed
ghost opened this issue Jan 31, 2016 · 6 comments
Closed

Comments

@ghost
Copy link

ghost commented Jan 31, 2016

When using "Medium mode" on uBlock 1.5.5 on Firefox 44, performing a search on The Pirate Bay lets in a popup for a split second before it disappears. As soon as the results page loads after performing a search, you can see a popup window appear and disappear. Shouldn't the popup be completely suppressed when using Medium mode?

No other blocking addons are installed.

@gorhill
Copy link
Owner

gorhill commented Jan 31, 2016

Popup blocking can't be done in a synchronous manner, there is no blocking API which can guarantee the popup window won't appear.

Using the no-popups switch should help as the popups are killed as soon as they are fired, but still there is no guarantee

@gorhill gorhill closed this as completed Jan 31, 2016
@gorhill
Copy link
Owner

gorhill commented Jan 31, 2016

Another trick: block inline script for the site, the popup code is triggered by inline script code on the page (inline scripting is not blocked in medium mode).

@jo2dan23
Copy link

jo2dan23 commented Feb 8, 2016

if you add this filter: /?placement=*&redirect$document

it will stop the connection to the ad domain.
screen shot 2016-02-08 at 5 24 16 pm

@ghost
Copy link
Author

ghost commented Feb 13, 2016

@jo2dan23 @gorhill Thanks for the pointers.

@ghost
Copy link
Author

ghost commented Feb 13, 2016

Couldn't uBO treat $popup as $document,popup? Then this request wouldn't be send. ❓

@gorhill
Copy link
Owner

gorhill commented Feb 13, 2016

Network requests and notifications about new tab or window opening are two different code paths. There is no way to prevent tab or window from opening, there is no blocking API for this.

gorhill pushed a commit that referenced this issue Sep 26, 2016
Add a "Block Resource" context menu command to the Firefox Network tab in devtools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants