Skip to content

Commit

Permalink
Add new scriptlet to allow blocking Amazon's apstag.js
Browse files Browse the repository at this point in the history
Related issues:
- NanoMeow/QuickReports#3717
- https://www.reddit.com/r/uBlockOrigin/comments/ghjqph/

The specific issue on the mentioned site is that the
site's code expect `window.apstag.fetchBids` to call
client-supplied function. The new scriptlet defuse this
by calling the client code with an empty array.
  • Loading branch information
gorhill committed May 11, 2020
1 parent 2b955fa commit f842ab6
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/js/redirect-engine.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ const redirectableResources = new Map([
[ 'amazon_ads.js', {
alias: 'amazon-adsystem.com/aax2/amzn_ads.js',
} ],
[ 'amazon_apstag.js', {
} ],
[ 'ampproject_v0.js', {
alias: 'ampproject.org/v0.js',
} ],
Expand Down
42 changes: 42 additions & 0 deletions src/web_accessible_resources/amazon_apstag.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/*******************************************************************************
uBlock Origin - a browser extension to block requests.
Copyright (C) 2019-present Raymond Hill
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see {http://www.gnu.org/licenses/}.
Home: https://github.com/gorhill/uBlock
*/

// https://www.reddit.com/r/uBlockOrigin/comments/ghjqph/
// https://github.com/NanoMeow/QuickReports/issues/3717

(function() {
'use strict';
const w = window;
const noopfn = function() {
; // jshint ignore:line
}.bind();
const apstag = {
fetchBids: function(a, b) {
if ( b instanceof Function ) {
b([]);
}
},
init: noopfn,
setDisplayBids: noopfn,
targetingKeys: noopfn,
};
w.apstag = apstag;
})();

0 comments on commit f842ab6

Please sign in to comment.