this fixes #42

gorhill · Apr 12, 2015 · bc49c40 · bc49c40
1 parent 65f6b36
commit bc49c40
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/platform/chromium/vapi-background.js b/platform/chromium/vapi-background.js
@@ -88,8 +88,8 @@ vAPI.tabs.registerListeners = function() {
     var popupCandidates = Object.create(null);
 
     var PopupCandidate = function(details) {
-        this.targetTabId = details.tabId;
-        this.openerTabId = details.sourceTabId;
+        this.targetTabId = details.tabId.toString();
+        this.openerTabId = details.sourceTabId.toString();
         this.targetURL = details.url;
         this.selfDestructionTimer = null;
     };

diff --git a/src/js/tab.js b/src/js/tab.js
@@ -137,7 +137,7 @@ housekeep itself.
     var gcPeriod = 10 * 60 * 1000;
 
     var TabContext = function(tabId) {
-        this.tabId = tabId;
+        this.tabId = tabId.toString();
         this.stack = [];
         this.rawURL =
         this.normalURL =
@@ -414,8 +414,8 @@ vAPI.tabs.onPopup = function(details) {
     //console.debug('vAPI.tabs.onPopup: details = %o', details);
 
     var tabContext = µb.tabContextManager.lookup(details.openerTabId);
-    var openerURL = details.openerURL || '';
-    if ( openerURL === '' && tabContext.tabId === details.openerTabId ) {
+    var openerURL = '';
+    if ( tabContext.tabId === details.openerTabId ) {
         openerURL = tabContext.normalURL;
     }