Make parser take into account filterOnHeaders setting

Related feedback: - uBlockOrigin/uBlock-issues#1134 (comment)
gorhill · Mar 8, 2023 · 890aaba · 890aaba
1 parent bbd9470
commit 890aaba
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/src/js/codemirror/ubo-static-filtering.js b/src/js/codemirror/ubo-static-filtering.js
@@ -288,6 +288,7 @@ CodeMirror.defineMode('ubo-static-filtering', function() {
                 hintHelperRegistered = true;
                 initHints();
             }
+            astParser.options.filterOnHeaders = details.filterOnHeaders === true;
         },
         parser: astParser,
     };

diff --git a/src/js/messaging.js b/src/js/messaging.js
@@ -1519,6 +1519,7 @@ const onMessage = function(request, sender, callback) {
             response.preparseDirectiveHints =
                 sfp.utils.preparser.getHints();
             response.expertMode = µb.hiddenSettings.filterAuthorMode;
+            response.filterOnHeaders = µb.hiddenSettings.filterOnHeaders;
         }
         if ( request.hintUpdateToken !== µb.pageStoresToken ) {
             response.originHints = getOriginHints();

diff --git a/src/js/static-filtering-parser.js b/src/js/static-filtering-parser.js
@@ -1221,7 +1221,7 @@ export class AstFilterParser {
                     realBad = isException === false || isNegated || hasValue;
                     break;
                 case NODE_TYPE_NET_OPTION_NAME_HEADER:
-                    realBad = this.expertMode === false || isNegated || hasValue === false;
+                    realBad = this.options.filterOnHeaders !== true || isNegated || hasValue === false;
                     break;
                 case NODE_TYPE_NET_OPTION_NAME_IMPORTANT:
                     realBad = isException || isNegated || hasValue;