Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove experimental click-to-load disqus scriptlets
As per AMO reviewer: > We will need you to remove the remote scripts in > > web_accessible_resources\disqus_embed.js - line 48 > web_accessible_resources\disqus_forums_embed.js - line 44 Related issue: - #1899
- Loading branch information
7c22a31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason given ?
7c22a31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can understand the reason. Summarily, the code is too confusing to follow to figure out what script is going to be loaded ultimately. This was added years ago as a preliminary experimentation to support a click-to-load feature. This can be better implemented in a way that is not ambiguous, so for now people will have to wait for the feature to be officially implemented, the experimental way has never be the proper way.