-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: env expand contents #721
Conversation
closes #719
Deploying with
|
Latest commit: |
33f1b30
|
Status: | ✅ Deploy successful! |
Preview URL: | https://219da237.nfpm.pages.dev |
Branch Preview URL: | https://contents-env-expand.nfpm.pages.dev |
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
==========================================
+ Coverage 75.08% 75.18% +0.10%
==========================================
Files 10 10
Lines 2412 2422 +10
==========================================
+ Hits 1811 1821 +10
Misses 425 425
Partials 176 176
|
Careful with this as we have rejected this in the past because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option is to opt-in into expanding: contents:
- src: '${NAME}_${ARCH}'
dst: /usr/bin/${NAME}
expand: true |
I like this solution, that way it is explicit that the user knows it will expand env vars |
pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #719