fix(rpm): conventionalfilename #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Deploying with
|
| Latest commit: |
9291134
|
| Status: | ⚡️ Build in progress... |
Codecov Report
@@ Coverage Diff @@
## main #715 +/- ##
==========================================
+ Coverage 75.02% 75.08% +0.06%
==========================================
Files 10 10
Lines 2406 2412 +6
==========================================
+ Hits 1805 1811 +6
Misses 425 425
Partials 176 176
|
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatVersion is also used to set the version field of the RPM, which should not contain the release.
this fixes it, and the tests which were wrong.
closes #714