-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: relative paths to dirs #576
Conversation
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
38e0ab0
to
119958f
Compare
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
==========================================
+ Coverage 70.22% 70.25% +0.02%
==========================================
Files 21 21
Lines 3130 3133 +3
==========================================
+ Hits 2198 2201 +3
Misses 715 715
Partials 217 217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, this change broke my use case. Please take a look here.
I have some files with the same name in EDIT: If I change
to
it works as before. No problem if this is the intended behaviour |
@drakkan yes, unfortunately this might be a breaking change for some... but I still think it was a bug before... I'll add a note about it in the release notes though. |
no problem, thanks |
closes #575