feat: add support for Arch Linux packages #543

Elara6331 · 2022-09-11T21:35:56Z

This PR adds support for Arch Linux packages.

Like the previous PR (#141), this one generates .PKGINFO, .INSTALL, and .MTREE files.

Unlike that PR, this one compresses the package with a pure-Go Zstandard implementation, which conforms with the new standard for Arch packages.

I have successfully been able to install packages generated by this code, so it works, but there are no tests, so I am leaving it as a draft until I add tests and more comments to it.

Closes #133
Closes #546

caarlos0 · 2022-09-11T23:18:02Z

amazing @Arsen6331! Let me know if you need any help!

codecov · 2022-09-12T02:34:31Z

Codecov Report

Merging #543 (31ab006) into main (1a66c73) will increase coverage by 0.68%.
The diff coverage is 73.37%.

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   69.31%   70.00%   +0.68%     
==========================================
  Files          20       21       +1     
  Lines        2581     3087     +506     
==========================================
+ Hits         1789     2161     +372     
- Misses        614      706      +92     
- Partials      178      220      +42

Impacted Files	Coverage Δ
apk/apk.go	`72.12% <0.00%> (-0.42%)`	⬇️
deb/deb.go	`71.16% <0.00%> (-0.27%)`	⬇️
internal/cmd/package.go	`0.00% <0.00%> (ø)`
internal/cmd/root.go	`0.00% <ø> (ø)`
nfpm.go	`86.56% <ø> (ø)`
rpm/rpm.go	`68.88% <0.00%> (-0.52%)`	⬇️
arch/arch.go	`74.40% <74.40%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Elara6331 · 2022-09-12T03:06:22Z

I've added the tests and comments, and fixed what the linter suggested.

caarlos0 · 2022-09-12T03:13:39Z

Thanks, @Arsen6331 🚀

could you make the changes to the docs as well? they live in the www folder.

Elara6331 · 2022-09-12T03:14:42Z

could you make the changes to the docs as well? they live in the www folder.

Sure

Elara6331 · 2022-09-12T03:33:09Z

I've changed the docs

arch/arch.go

Co-authored-by: Dj Gilcrease <digitalxero@gmail.com>

djgilcrease

Implement signed packages https://wiki.archlinux.org/title/DeveloperWiki:Package_signing Appears to create a .sig file to live outside the package?
Implement acceptance tests

Elara6331 · 2022-09-13T00:55:12Z

Implement signed packages wiki.archlinux.org/title/DeveloperWiki:Package_signing Appears to create a .sig file to live outside the package?

Yeah, it requires a separate file and I don't know how to implement that with the current API.

Elara6331 · 2022-09-15T01:36:52Z

Done

djgilcrease

LGTM

Elara6331 · 2022-09-17T01:59:59Z

I could also try to make a PR against https://github.com/goreleaser/goreleaser that integrates these changes and can be merged once they make it into a release.

caarlos0

on a first look it looks good to me! will see if I find some arch contributor to help review it as well!

thanks again for the work on this! ❤️

apk/apk.go

caarlos0 · 2022-09-20T01:16:45Z

I could also try to make a PR against https://github.com/goreleaser/goreleaser that integrates these changes and can be merged once they make it into a release.

if you feel like it, go for it! If not, I can do it as well, no issues :)

Elara6331 · 2022-09-22T21:05:11Z

I went through a bunch of PKGBUILDs on the AUR to see if I missed anything and implemented all of it.

caarlos0 · 2022-10-13T20:35:02Z

I'll review this again today and see that we have it merge soon! 🙏 Sorry for the delay, had a crazy couple of weeks :P

Elara6331 · 2022-10-13T20:56:51Z

I'll review this again today and see that we have it merge soon! pray Sorry for the delay, had a crazy couple of weeks :P

No problem. Merge it whenever it's convenient for you, there's no rush.

This PR upgrades nFPM to v0.20.0, and integrates the new `ConventionalExtension` method to use the correct extension for the packaging format that is being used.  Currently, goreleaser uses the name of the format to determine the extension. This has worked fine, but with the introduction of Archlinux packages, goreleaser has to handle packages with extensions that don't match the name of the format, since Archlinux uses `.pkg.tar.zst` as the extension.  goreleaser/nfpm#546 goreleaser/nfpm#543

azat · 2022-10-16T20:11:16Z

Apparently right now archlinux packager does not support type=config for directories:

nfpm package --target .. --config clickhouse-server.yaml --packager archlinux
using archlinux packager...
read root/etc/clickhouse-server: is a directory

caarlos0 · 2022-10-17T11:59:46Z

Apparently right now archlinux packager does not support type=config for directories:
nfpm package --target .. --config clickhouse-server.yaml --packager archlinux
using archlinux packager...
read root/etc/clickhouse-server: is a directory

can you open an issue/PR?

Since nfpm v2.20.0 it can build packages for archlinux [1]. [1]: goreleaser/nfpm#543 Something like this: $ mkdir -p /src/packages/root $ cmake -DCMAKE_INSTALL_PREFIX=/usr /src $ DESTDIR=/src/packages/root ninja install $ cd /src/packages $ ./build --archlinux $ root@s3:/src/packages# ./build --archlinux Current version is 22.10.1.1 Building archlinux package for clickhouse-client.yaml using archlinux packager... created package: /src/clickhouse-client-22.10.1.1-1-x86_64.pkg.tar.zst ... Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

azat · 2022-10-23T20:59:09Z

can you open an issue/PR?

#564

This PR implements the Archlinux packages that were added in nfpm v2.20.0, as well as tests and documentation for them.   goreleaser/nfpm#133 goreleaser/nfpm#543 Fixes #3469 Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

feat: add support for Arch Linux packages

9621f48

pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 11, 2022

Elara6331 added 9 commits September 11, 2022 18:19

test: Add initial tests

800db22

test: Increase coverage by modifying example info

e76830c

test: Add test for ArchLinux.ConventionalFileName()

b33d642

docs: Return error if package name is invalid

ff3851c

fix: Make empty name invalid

2068f22

fix: Add replaces field to .PKGINFO generator

4219aad

test: Add additional tests

af7817e

test: Test for added replaces field

1e1fe66

docs: Add more comments

2170154

Elara6331 marked this pull request as ready for review September 12, 2022 02:30

Elara6331 added 2 commits September 11, 2022 19:50

style: Run gofumpt

0d9cb16

fix: Handle errors as recommended by linter

f7e4982

caarlos0 added the enhancement New feature or request label Sep 12, 2022

Elara6331 added 3 commits September 11, 2022 20:15

fix: Allow changing the pkgbase

c5c7bb4

style: Resolve semgrep findings

549cd4a

docs: Change docs to reflect new Arch Linux packager

72b40b8

Elara6331 mentioned this pull request Sep 12, 2022

Handle packaging formats with non-distinct file extensions #546

Closed

2 tasks

djgilcrease requested changes Sep 13, 2022

View reviewed changes

arch/arch.go Outdated Show resolved Hide resolved

Elara6331 and others added 2 commits September 13, 2022 00:26

docs: Fix spelling mistake in comment

c5dfae6

Co-authored-by: Dj Gilcrease <digitalxero@gmail.com>

docs: use aspell to fix all spelling mistakes

19a84eb

djgilcrease requested changes Sep 13, 2022

View reviewed changes

Elara6331 and others added 2 commits September 14, 2022 18:49

test: Use updated build.yml from main branch

b3e7c15

Merge branch 'main' into add-archlinux-pkgs

079592b

djgilcrease approved these changes Sep 15, 2022

View reviewed changes

caarlos0 reviewed Sep 20, 2022

View reviewed changes

apk/apk.go Outdated Show resolved Hide resolved

Elara6331 added 3 commits September 20, 2022 01:18

Fix ConventionalExtension() for apk

19e2c24

fix: Take epoch value into account

c0e6c43

fix: Add arm5 and arm6 architectures

eae88e8

Merge branch 'main' into add-archlinux-pkgs

31ab006

caarlos0 merged commit a18661b into goreleaser:main Oct 15, 2022

github-actions bot added this to the v2.20.0 milestone Oct 15, 2022

Elara6331 mentioned this pull request Oct 15, 2022

feat: integrate ConventionalExtension from nfpm v2.20.0 goreleaser/goreleaser#3468

Merged

Elara6331 mentioned this pull request Oct 15, 2022

feat: implement nfpm archlinux packages goreleaser/goreleaser#3470

Merged

Elara6331 deleted the add-archlinux-pkgs branch October 16, 2022 09:12

azat mentioned this pull request Oct 16, 2022

Use nfpm packager for archlinux packages ClickHouse/ClickHouse#42349

Merged

tonobo mentioned this pull request Mar 1, 2023

archlinux package signing #628

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for Arch Linux packages #543

feat: add support for Arch Linux packages #543

Elara6331 commented Sep 11, 2022 •

edited

Loading

caarlos0 commented Sep 11, 2022

codecov bot commented Sep 12, 2022 •

edited

Loading

Elara6331 commented Sep 12, 2022

caarlos0 commented Sep 12, 2022

Elara6331 commented Sep 12, 2022

Elara6331 commented Sep 12, 2022

djgilcrease left a comment •

edited

Loading

Elara6331 commented Sep 13, 2022

Elara6331 commented Sep 15, 2022

djgilcrease left a comment

Elara6331 commented Sep 17, 2022

caarlos0 left a comment

caarlos0 commented Sep 20, 2022

Elara6331 commented Sep 22, 2022

caarlos0 commented Oct 13, 2022

Elara6331 commented Oct 13, 2022

azat commented Oct 16, 2022

caarlos0 commented Oct 17, 2022

azat commented Oct 23, 2022

feat: add support for Arch Linux packages #543

feat: add support for Arch Linux packages #543

Conversation

Elara6331 commented Sep 11, 2022 • edited Loading

caarlos0 commented Sep 11, 2022

codecov bot commented Sep 12, 2022 • edited Loading

Codecov Report

Elara6331 commented Sep 12, 2022

caarlos0 commented Sep 12, 2022

Elara6331 commented Sep 12, 2022

Elara6331 commented Sep 12, 2022

djgilcrease left a comment • edited Loading

Choose a reason for hiding this comment

Elara6331 commented Sep 13, 2022

Elara6331 commented Sep 15, 2022

djgilcrease left a comment

Choose a reason for hiding this comment

Elara6331 commented Sep 17, 2022

caarlos0 left a comment

Choose a reason for hiding this comment

caarlos0 commented Sep 20, 2022

Elara6331 commented Sep 22, 2022

caarlos0 commented Oct 13, 2022

Elara6331 commented Oct 13, 2022

azat commented Oct 16, 2022

caarlos0 commented Oct 17, 2022

azat commented Oct 23, 2022

Elara6331 commented Sep 11, 2022 •

edited

Loading

codecov bot commented Sep 12, 2022 •

edited

Loading

djgilcrease left a comment •

edited

Loading