Hl student UI update #2182
Hl student UI update #2182
Conversation
…tting the application.
src/views/HousingLottery/studentView/StudentApplicants/ApplicantFields/index.jsx
Show resolved
Hide resolved
|
I added an email auto-complete function too. So, this branch has some minor improvements in the student UI. |
JayBae9903
added
3 Points
|
As for the 3rd thing you did, that's exactly what I did couple months ago and we already have it implemented. if you weren't able to do full validation of the email, can you just remove the fixes you made for that function? |
The problem I found was when I tried to submit the application with invalid emails, I was able to submit it. So I think the email validation function is not working now. |
There was a problem hiding this comment.
align the code format, approved
There was a problem hiding this comment.
I already made a few changes on the instruction page by removing some unnecessary text
| <Typography variant="body1" paragraph> | ||
| <strong>5. Do I need to be registered for classes to complete the questionnaire?</strong><br/> |
There was a problem hiding this comment.
Necessary text change starting from here
| <br /> | ||
| If you would like confirmation that your questionnaire has been received, you will need | ||
| to select the “Send me an email receipt of my responses” box at the bottom of the | ||
| questionnaire. No other confirmation will be provided. |
There was a problem hiding this comment.
Keep a note here to reserve the text change until here
There was a problem hiding this comment.
why you think here should to have a new variable to store the preference option as newloudorQuiet? I don't think it's neceesary
| @@ -73,6 +73,11 @@ const Preference = ({ onPreferenceChange }) => { | |||
| } | |||
| }, []); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
Why add a new useEffect here to check valid for selected option?
There was a problem hiding this comment.
Approve the change here
There was a problem hiding this comment.
don't save the code change here
There was a problem hiding this comment.
Jay, please read my code review carefully. Since there are a few changed we already made in the senior project which causing your PR has conflicts with the current senior-project, I suggest you to create a new branch based on the senior-project and bring the code changes I marked as necessary into the new PR please. Thanks for your work
Here's what I did: