Fix Python 3.6 installation when the OS locale is set to POSIX #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To fix errors, maybe this line at the top of the file would be enough: from codecs import openAlso, can you add your GH nickname + history change? I am thinking of something like: - Fixed Python 3.6 installation when the OS locale is set to POSIX (`#615 <https://github.com/gorakhargosh/watchdog/pull/615>`__) |
Good shout, was going to go via |
BoboTiG
changed the title
|
Thanks a lot @tehkirill :) |
|
@BoboTiG are you able to cut a release to pypi? |
|
A new pypi release would be very helpful. |
|
@darakian Done :) |
|
Thank you much @BoboTiG :) |
CCP-Aporia
pushed a commit
to CCP-Aporia/watchdog
that referenced
this pull request
Aug 13, 2020
…hargosh#616) * enforce 'utf-8' encoding, fixes gorakhargosh#615 * using `open` from `codecs` for py2.7 support * Updated changelog to reflect OS locale fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615.