Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gox => gogen #402

Merged
merged 1 commit into from
Mar 8, 2024
Merged

gox => gogen #402

merged 1 commit into from
Mar 8, 2024

Conversation

xushiwei
Copy link
Member

@xushiwei xushiwei commented Mar 8, 2024

No description provided.

@@ -138,12 +138,12 @@ func codeErrorTestDo(t *testing.T, pkg *gox.Package, msg string, source func(pkg
}
source(pkg)
var b bytes.Buffer
gox.WriteTo(&b, pkg, "")
gogen.WriteTo(&b, pkg, "")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] Error return value of gogen.WriteTo is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

func(cb *gox.CodeBuilder) {
cb.Member("string", gox.MemberFlagAutoProperty)
func(cb *gogen.CodeBuilder) {
cb.Member("string", gogen.MemberFlagAutoProperty)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] Error return value of cb.Member is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

@@ -1408,7 +1408,7 @@ func TestDeleteVarDecl(t *testing.T) {
}
defs.Delete("b")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] Error return value of defs.Delete is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

@@ -1408,7 +1408,7 @@ func TestDeleteVarDecl(t *testing.T) {
}
defs.Delete("b")
defs.Delete("c")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] Error return value of defs.Delete is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

t.Fatal("cb.Member v.attr no error?", kind)
}
cb.Member("attr", gox.MemberFlagMethodAlias)
cb.Member("attr", gogen.MemberFlagMethodAlias)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] Error return value of cb.Member is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

Debug(func(cb *gox.CodeBuilder) {
cb.Member("len", gox.MemberFlagAutoProperty)
Debug(func(cb *gogen.CodeBuilder) {
cb.Member("len", gogen.MemberFlagAutoProperty)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] Error return value of cb.Member is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

@xushiwei xushiwei merged commit 010bb4b into goplus:main Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant