Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initThisGopPkg: add interface overload method to named #327

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented Dec 25, 2023

type NodeSeter interface {
	Len__0() int
	Attr__0(k string, exactlyOne ...bool) (text string, err error)
	Attr__1(k, v string) (ret NodeSeter)
}

*types.Named.Underlying().(*types.Interface) => interface

interface {
	Len__0() int
	Attr__0(k string, exactlyOne ...bool) (text string, err error)
	Attr__1(k, v string) (ret NodeSeter)
}

*types.Named => add overload

method Len(__gop_overload_args__ interface{_()})
method Attr(__gop_overload_args__ interface{_()})

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01dc571) 95.27% compared to head (db834d5) 95.28%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   95.27%   95.28%           
=======================================
  Files          14       14           
  Lines        6483     6489    +6     
=======================================
+ Hits         6177     6183    +6     
  Misses        239      239           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiwei xushiwei merged commit a6c41ff into goplus:main Dec 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants