Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project page for community #999

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Project page for community #999

merged 3 commits into from
Oct 21, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Oct 18, 2024 •
edited
Loading

@qiniu-prow qiniu-prow
Copy link

qiniu-prow bot commented Oct 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nighca nighca marked this pull request as ready for review October 18, 2024 08:40
aofei
aofei reviewed Oct 21, 2024
View reviewed changes
spx-gui/src/components/community/user/UserAvatar.vue Outdated

const props = defineProps<{
owner: string | User
user: string | User | null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里啥时候会为 null？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

外部组件直接给 UserAvatar user 信息（User），但是外部组件自己也还在加载 user 信息中的时候

这会儿如果选择通过 v-if 控制不渲染 UserAvatar，布局会有抖动，所以传个 null 进来让 UserAvatar 先占个位

Copy link
Collaborator Author

@nighca nighca Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不过我又检查了下，现在已经没有这个情况了，这个 null 应该可以干掉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 null 应该可以干掉

cc13f9d

@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@nighca nighca merged commit 7f71dee into goplus:dev Oct 21, 2024
4 checks passed
aofei added a commit to aofei/.goplus.builder that referenced this pull request Oct 21, 2024
@aofei
fix: check isLiking only when signed in
95148c6 
Related to goplus#999.

Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
@aofei aofei mentioned this pull request Oct 21, 2024
Merged
nighca pushed a commit that referenced this pull request Oct 22, 2024
@aofei
fix: check isLiking only when signed in (#1005)
32b7dd7 
Related to #999.

Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aofei aofei aofei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Community Project Page
3 participants
@nighca @qiniu-ci @aofei