refactor: improve project sharing UX #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aofei
force-pushed
the
share-project
branch
from
6e02d3e to
7139ea4
Compare
aofei
force-pushed
the
share-project
branch
from
7139ea4 to
9be2eb6
Compare
aofei
force-pushed
the
share-project
branch
from
9be2eb6 to
416e552
Compare
nighca
reviewed
Sep 10, 2024
| resolved: [] | ||
| }>() | ||
|
|
||
| const form = useForm({}) |
There was a problem hiding this comment.
这边用 UIForm、UIFormItem 是为了复用它的样式吗
要是没有用到它们的样式，建议不去依赖它们了；目前它们的功能及接口主要是针对带校验、可提交的表单设计的，比如这里构造一个空的 form 再传入就显得有点多余
There was a problem hiding this comment.
Fixes goplus#847 Fixes goplus#848 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
aofei
force-pushed
the
share-project
branch
from
416e552 to
2cfac80
Compare
nighca
approved these changes
Sep 10, 2024
|
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after a certain period of time., please make sure to test it in time. If you have any questions, please contact the builder team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #847
Fixes #848