unique id for models #817
Merged
unique id for models #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ComfyFluffy
commented
Aug 28, 2024
ComfyFluffy
commented
- modify id for model
- name -> id
nighca
reviewed
Aug 29, 2024
nighca
reviewed
Sep 2, 2024
| @@ -226,12 +220,13 @@ export class Sprite extends Disposable { | |||
| this.addDisposer(() => { | |||
| this.animations.splice(0).forEach((a) => a.dispose()) | |||
| }) | |||
| // This should be set after the animations are created | |||
There was a problem hiding this comment.
mark: 这里是之前的 animation load 逻辑不太合理造成的，我回头改一下
Closed
Closed
nighca
reviewed
Sep 3, 2024
nighca
approved these changes
Sep 3, 2024
|
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after a certain period of time., please make sure to test it in time. If you have any questions, please contact the builder team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.