Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages' title #1023

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Pages' title #1023

merged 7 commits into from
Oct 25, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Oct 24, 2024

Copy link

qiniu-prow bot commented Oct 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nighca nighca changed the title Issue 1008 Pages' title Oct 24, 2024
@nighca nighca marked this pull request as ready for review October 25, 2024 01:04
@@ -108,6 +108,7 @@ export class Project extends Disposable {
visibility?: Visibility
description?: string
instructions?: string
/** Universal URL of the project's thumbnail image, may be empty (`""`) */
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aofei 我们昨天说到的是,如果 thumbnail 为空(""),publish 的时候会有问题对吧?这个我单独 PR 处理下

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

昨天说的好像是 thumbnail 为空的话 ProjectItem 之类的地方会没有东西显示,看起来比较奇怪。好像没说 publish 相关的?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

噢明白了,publish 也会有问题,现在如果 thumbnail 为空,在 project 页面(而不是编辑器中)去 publish 的话会没法 publish(没有 screenshotTaker)..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果直接带着 q 参数进入页面的话(比如别人分享的链接),比如 http://localhost:5173/search?q=test,是不是也应该把 q 同步进输入框?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯这样会稍好点,我看怎么加一下

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 233e960

@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit 0189fb8 into goplus:dev Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community Search Input Clearing Community Pages' title
3 participants