-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages' title #1023
Pages' title #1023
Conversation
Skipping CI for Draft Pull Request. |
@@ -108,6 +108,7 @@ export class Project extends Disposable { | |||
visibility?: Visibility | |||
description?: string | |||
instructions?: string | |||
/** Universal URL of the project's thumbnail image, may be empty (`""`) */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aofei 我们昨天说到的是,如果 thumbnail 为空(""
),publish 的时候会有问题对吧?这个我单独 PR 处理下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
昨天说的好像是 thumbnail 为空的话 ProjectItem
之类的地方会没有东西显示,看起来比较奇怪。好像没说 publish 相关的?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
噢明白了,publish 也会有问题,现在如果 thumbnail 为空,在 project 页面(而不是编辑器中)去 publish 的话会没法 publish(没有 screenshotTaker
)..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果直接带着 q
参数进入页面的话(比如别人分享的链接),比如 http://localhost:5173/search?q=test
,是不是也应该把 q
同步进输入框?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯这样会稍好点,我看怎么加一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 233e960
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
displayName
instead ofname
for user displaying