Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and improve project setup #41

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Update dependencies and improve project setup #41

merged 6 commits into from
Aug 14, 2023

Conversation

ravilushqa
Copy link
Contributor

Updated Go version and all module dependencies in go.mod for better compatibility and performance. Added an 'init-tools' makefile target to ensure all required tools for development are installed and properly set up. Adjusted 'lint' target to use local golangci-lint. Made minor code style adjustment in httptest.go. Added tools like go.sum and tools.go for better tracking and consistency of development tools. Changes are made for improving project setup and future maintenance.

Updated Go version and all module dependencies in go.mod for better compatibility and performance. Added an 'init-tools' makefile target to ensure all required tools for development are installed and properly set up. Adjusted 'lint' target to use local golangci-lint. Made minor code style adjustment in httptest.go. Added tools like go.sum and tools.go for better tracking and consistency of development tools. Changes are made for improving project setup and future maintenance.
# Conflicts:
#	go.mod
#	go.sum
Updated the Go version in GitHub workflows from 1.18 and 1.19 to 1.21 for better compatibility with newer features and performance improvements. The golangci-lint version was also updated for more recent bug-fixes and changes. These updates ensure that the CI environment used for automated testing and linting is in sync with the latest Go language version, hence provides better support for the latest Go language syntax, features, and modules.
Removed Go version 1.20.x from the GitHub workflows' compatibility-test and kept version 1.21.x to ensure our codebase matches the latest Go syntax, features, and modules. This change is aimed at enhancing performance and compatibility.
This commit removes the golangci-lint.yml workflow file as the linting process is now integrated into the test.yml workflow, reducing redundancy and streamlining CI/CD operations. Additionally, a Logger interface was introduced in the server.go file to improve logging practices across the application.
Logger interface has been removed from httpinfra/server.go as part of a refactoring process. This change is made to further separate concerns in the codebase, improving maintainability. Logger interface will be introduced elsewhere as necessary.
@ravilushqa ravilushqa merged commit 2e1ba36 into main Aug 14, 2023
@ravilushqa ravilushqa deleted the go1.21 branch August 14, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant