Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for recent Unity iOS and google signin libraries #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

umegaya
Copy link

@umegaya umegaya commented Sep 6, 2019

purpose

  • I was trying to use this project with play-services-resolver-1.2.124.0 and found:
    • opened with recent Unity Editor, build was failed
    • for iOS, generated xcode project is broken.
  • this PR aims to:
    • fix various problem to make this project work with recent Unity and google signin libraries
    • make the plugin be easier for user to integrate their OAuth setting (docs not so clear and not automated with PostProcessBuild)

fixes

  • removes Unity.Tasks.dll because recent Unity has built in support for it
  • removes missing symbols of GIDSignin (function, error code)
  • swap preStartUnity instead of application:didFinishLaunchingWithOptions: of UnityAppController with GoogleSignInController version. because recent GIDSignin required to set presentingViewController to work, but correct UIViewController cannot be retrieved on application:didFinishLaunchingWithOptions being called.
  • add post processor to make generated Unity Xcode project be able to run with user's OAuth credentials settings. it does:
    • find file which name is GoogleService-Info.plist and copy it to root of xcode project dir
    • read above file and set value of REVERSED_CLIENT_ID as custom URL Type
  • added GoogleSignIn_CanBeSilent to C linkage codes

question

  • various type of GIDSignin handleURL is missing. how do I handle these with recent lib?

…nd google signin libraries

  - removes Unity.Tasks.dll because recent Unity has built in support for it
  - removes missing symbols of GIDSignin (function, error code)
  - swap preStartUnity instead of application:didFinishLaunchingWithOptions: because recent GIDSignin required to set presentingViewController to work, and correct UIViewController cannot be retrieved application:didFinishLaunchingWithOptions timing.
  - add general PostProcessor to generated Unity Xcode project can run with OAuth credentials settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant