fix: outputEncoding is deprecated in three >= 0.152 #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Since the default was changed to sRGB (mrdoob/three.js#25783) with the same release, the encoding can be dropped completely for three.js versions 152 and above. I think this library should still keep support for older three.js versions for some time, so a check with |
|
Added revision check for backwards compatibility and removed outputColorSpace. // Since r152, default outputColorSpace is SRGB
// Deprecated outputEncoding kept for backwards compatibility
if (Number(REVISION) < 152) this.renderer.outputEncoding = sRGBEncoding; |
usefulthink
approved these changes
Jun 5, 2023
usefulthink
changed the title
googlemaps-bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
### [4.0.2](v4.0.1...v4.0.2) (2023-06-08) ### Bug Fixes * outputEncoding is deprecated in three >= 0.152 ([#743](#743)) ([dd9f9fd](dd9f9fd)) ### Miscellaneous Chores * **deps-dev:** bump @babel/preset-env from 7.21.5 to 7.22.2 ([#730](#730)) ([2cfe690](2cfe690)) * **deps-dev:** bump @babel/preset-env from 7.22.2 to 7.22.4 ([#734](#734)) ([fa5d600](fa5d600)) * **deps-dev:** bump @babel/runtime-corejs3 from 7.21.5 to 7.22.3 ([#727](#727)) ([45c8660](45c8660)) * **deps-dev:** bump @googlemaps/jest-mocks from 2.18.1 to 2.19.0 ([#711](#711)) ([dd8dfaf](dd8dfaf)) * **deps-dev:** bump @googlemaps/jest-mocks from 2.19.0 to 2.19.1 ([#719](#719)) ([716a0d5](716a0d5)) * **deps-dev:** bump @googlemaps/js-api-loader from 1.15.1 to 1.15.2 ([#716](#716)) ([a684b3a](a684b3a)) * **deps-dev:** bump @rollup/plugin-commonjs from 24.1.0 to 25.0.0 ([#715](#715)) ([5001e36](5001e36)) * **deps-dev:** bump @rollup/plugin-node-resolve from 15.0.2 to 15.1.0 ([#733](#733)) ([d434288](d434288)) * **deps-dev:** bump @rollup/plugin-terser from 0.4.1 to 0.4.3 ([#722](#722)) ([549651f](549651f)) * **deps-dev:** bump @rollup/plugin-typescript from 11.1.0 to 11.1.1 ([#708](#708)) ([298ee53](298ee53)) * **deps-dev:** bump @types/google.maps from 3.53.0 to 3.53.1 ([#713](#713)) ([67429e2](67429e2)) * **deps-dev:** bump @types/google.maps from 3.53.1 to 3.53.2 ([#729](#729)) ([e7b09af](e7b09af)) * **deps-dev:** bump @types/jest from 29.5.1 to 29.5.2 ([#738](#738)) ([d027cca](d027cca)) * **deps-dev:** bump @types/selenium-webdriver from 4.1.14 to 4.1.15 ([#725](#725)) ([7b5330a](7b5330a)) * **deps-dev:** bump @types/three from 0.150.1 to 0.152.0 ([#706](#706)) ([f83d5e5](f83d5e5)) * **deps-dev:** bump @types/three from 0.152.0 to 0.152.1 ([#724](#724)) ([c9e2804](c9e2804)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#709](#709)) ([03e44b0](03e44b0)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#721](#721)) ([dd2027a](dd2027a)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#731](#731)) ([e269dde](e269dde)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#741](#741)) ([4a3c9bb](4a3c9bb)) * **deps-dev:** bump @typescript-eslint/parser from 5.59.1 to 5.59.2 ([#698](#698)) ([20189a6](20189a6)) * **deps-dev:** bump @typescript-eslint/parser from 5.59.2 to 5.59.5 ([#710](#710)) ([4b9d889](4b9d889)) * **deps-dev:** bump @typescript-eslint/parser from 5.59.5 to 5.59.6 ([#718](#718)) ([5210be0](5210be0)) * **deps-dev:** bump @typescript-eslint/parser from 5.59.6 to 5.59.7 ([#728](#728)) ([60d390f](60d390f)) * **deps-dev:** bump @typescript-eslint/parser from 5.59.7 to 5.59.8 ([#735](#735)) ([4467035](4467035)) * **deps-dev:** bump chromedriver from 113.0.0 to 114.0.1 ([#732](#732)) ([b07fda6](b07fda6)) * **deps-dev:** bump eslint from 8.40.0 to 8.41.0 ([#723](#723)) ([882421f](882421f)) * **deps-dev:** bump eslint from 8.41.0 to 8.42.0 ([#736](#736)) ([1f893a8](1f893a8)) * **deps-dev:** bump geckodriver from 3.2.0 to 4.0.0 ([#717](#717)) ([12f13cb](12f13cb)) * **deps-dev:** bump geckodriver from 4.0.0 to 4.0.2 ([#726](#726)) ([92ebe70](92ebe70)) * **deps-dev:** bump rollup from 3.21.5 to 3.21.7 ([#712](#712)) ([cc6ad32](cc6ad32)) * **deps-dev:** bump rollup from 3.21.7 to 3.23.0 ([#720](#720)) ([de60c63](de60c63)) * **deps-dev:** bump rollup from 3.23.0 to 3.23.1 ([#740](#740)) ([49f34eb](49f34eb)) * **deps-dev:** bump selenium-webdriver from 4.9.0 to 4.9.2 ([#714](#714)) ([a7bd7e7](a7bd7e7)) * **deps-dev:** bump three from 0.152.2 to 0.153.0 ([#739](#739)) ([bb89eda](bb89eda)) * **deps-dev:** bump typedoc from 0.24.7 to 0.24.8 ([#737](#737)) ([c8a328e](c8a328e)) * Update release.yml ([0173ba9](0173ba9))
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple import/name change
Fixes #742