Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mock elevation service #408

Merged
merged 6 commits into from
Mar 23, 2023

Conversation

BiniCodes
Copy link
Contributor

  • adds mock for elevation service
  • adds test for elevation service mock

Closes #394

@amuramoto
Copy link
Member

@BiniCodes can you please take a look at the test failures for this PR? Thank you!

@BiniCodes
Copy link
Contributor Author

@BiniCodes can you please take a look at the test failures for this PR? Thank you!

Sure!

In this case the operator satisfies is only available for typescript >=4.9. I can replace it to as for now, but it should work with satisfies as well after #376 is merged :)

@BiniCodes BiniCodes requested a review from amuramoto March 16, 2023 13:10
@amuramoto
Copy link
Member

@BiniCodes Looks like there is an issue with the tests - can you take a look? Thanks!

@BiniCodes BiniCodes requested a review from amuramoto March 23, 2023 17:58
@amuramoto amuramoto merged commit c2e2ad0 into googlemaps:main Mar 23, 2023
github-actions bot pushed a commit that referenced this pull request Mar 23, 2023
* feat: add mock elevation service

* fix(elevation-service): fix typo

---------

Co-authored-by: Alex Muramoto <amuramoto@users.noreply.github.com> c2e2ad0
googlemaps-bot pushed a commit that referenced this pull request Mar 23, 2023
## [2.18.0](v2.17.2...v2.18.0) (2023-03-23)

### Features

* add mock elevation service ([#408](#408)) ([c2e2ad0](c2e2ad0))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElevationService: Add mock for google.maps.ElevationService
4 participants