Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescipt and eslint errors #406

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

BiniCodes
Copy link
Contributor

  • Fixes type errors in different files
  • Fixes an eslint error

Fixes #389 🩹

@amuramoto
Copy link
Member

@BiniCodes can you please take a look at the test failures for this PR? Thank you!

@BiniCodes
Copy link
Contributor Author

@BiniCodes can you please take a look at the test failures for this PR? Thank you!

I think this one needs as well the new google.maps types, as it doesn't like the FeatureLayer, MapCapabilities and FeatureType. #403

@amuramoto
Copy link
Member

@BiniCodes Can you take another look at the test failure and merge conflict in this one? Thanks!

@BiniCodes
Copy link
Contributor Author

@BiniCodes Can you take another look at the test failure and merge conflict in this one? Thanks!

I'll quickly why there are still errors popping up after merging 👍

@BiniCodes BiniCodes requested a review from amuramoto March 23, 2023 17:49
@amuramoto amuramoto merged commit 3d0da9f into googlemaps:main Mar 23, 2023
github-actions bot pushed a commit that referenced this pull request Mar 23, 2023
* fix: typescipt and eslint errors

* style(map): remove whitespace

* fix(panorama): remove double implementation of focus 3d0da9f
googlemaps-bot pushed a commit that referenced this pull request Mar 23, 2023
### [2.17.2](v2.17.1...v2.17.2) (2023-03-23)

### Bug Fixes

* typescipt and eslint errors ([#406](#406)) ([3d0da9f](3d0da9f))

### Miscellaneous Chores

* **deps-dev:** bump eslint from 7.32.0 to 8.36.0 ([#412](#412)) ([77688b1](77688b1))
* **deps-dev:** bump typedoc from 0.23.27 to 0.23.28 ([#413](#413)) ([7db11ad](7db11ad))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.17.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript errors
4 participants